Prevent the selected tab from being refocused when local DOM elements of the menu are focused.

PolymerElements / iron-menu-behavior

Accessible menu behavior

18 stars 28 forks source link

Prevent the selected tab from being refocused when local DOM elements of the menu are focused. #36

Closed bicknellr closed 8 years ago

bicknellr commented 9 years ago

Fixes PolymerElements/paper-tabs#65.

bicknellr commented 9 years ago

(needs Polymer/polymer#2717)

cdata commented 9 years ago

Left some feedback, PTAL!

bicknellr commented 9 years ago

Fixed up the stuff you mentioned.

cdata commented 8 years ago

@bicknellr please rebase this PR :baseball:

cdata commented 8 years ago

Man, what happened to the test suite here? Looks like a lot of broken :hankey: ..

bicknellr commented 8 years ago

@cdata The tests use document.activeElement but assume there's no retargeting for shadow DOM boundaries, so I fixed them and made this PR dependent upon Polymer/polymer#2717.

bicknellr commented 8 years ago

Polymer/polymer#2717 is in. I wct --sauce default'd this with Polymer master and it passes, but that PR isn't in a release yet. Once it is, I'll bump the dependency version and the tests should start passing here.

bicknellr commented 8 years ago

@cdata, Polymer/polymer#2717 is now in a release.

cdata commented 8 years ago

Ship it! :shipit: