Prevent event default behavior (scrolling) on arrow key press.

PolymerElements / iron-menu-behavior

Accessible menu behavior

18 stars 28 forks source link

Prevent event default behavior (scrolling) on arrow key press. #46

Closed bicknellr closed 8 years ago

bicknellr commented 8 years ago

Fixes PolymerElements/paper-menu#79.

notwaldorf commented 8 years ago

Also, pls consider https://github.com/PolymerElements/iron-menu-behavior/pull/30/files, and if that needs to be merged as well

bicknellr commented 8 years ago

Whoa, thanks; this and #30 might both be able to be closed just by setting stop-keyboard-event-propagation.

bicknellr commented 8 years ago

Gah, this is already there...

bicknellr commented 8 years ago

Since this needs to call preventDefault rather than stopPropagation the stop-keyboard-event-propagation flag isn't going to work, so I just called preventDefault in the relevant arrow key cases.

notwaldorf commented 8 years ago

LGTM