search

PolymerElements / iron-menu-behavior

Accessible menu behavior
18 stars 28 forks source link

2.0-preview branch #78

Closed bicknellr closed 7 years ago

googlebot commented 7 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

bicknellr commented 7 years ago

I need to merge master again to get changes from v1.3.0 . Depends on #91 though.

e111077 commented 7 years ago

@bicknellr feel free to assign me to that PR

bicknellr commented 7 years ago

(^ #92 is the PR with a fix for #91.)

bicknellr commented 7 years ago

Ok, #92 is merged into master and master merged into 2.0-preview.

e111077 commented 7 years ago

@bicknellr cool, any new info on _activeElement?

bicknellr commented 7 years ago

@e111077, yup, _activeElement doesn't seem necessary anymore: wrapping w/ Polymer.dom should make activeElement work in 1.x & 2.x: 1.x (Shady DOM) https://github.com/Polymer/polymer/blob/afb233ce812b2b4971ab9aa51a8fdff96a571441/src/lib/dom-api-shady.html#L458 1.x (Shadow DOM) https://github.com/Polymer/polymer/blob/afb233ce812b2b4971ab9aa51a8fdff96a571441/src/lib/dom-api-shadow.html#L61 2.x https://github.com/Polymer/polymer/blob/1478a0680ab822e786eee0ad93c9d8937bff31d4/lib/legacy/polymer.dom.html#L177