PolymerElements / iron-menu-behavior

Accessible menu behavior
18 stars 28 forks source link

Fix a bug where iron-menu-behavior swallowed all keydown #83

Open lghall opened 8 years ago

lghall commented 8 years ago

This fixes #82 by only calling stopPropagation() on the event if an item was actually focused.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


lghall commented 8 years ago

I have signed the CLA as part of Google, Inc.

On Wed, Nov 2, 2016 at 2:32 PM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PolymerElements/iron-menu-behavior/pull/83#issuecomment-257957975, or mute the thread https://github.com/notifications/unsubscribe-auth/AV1Gp_CRi3sVzBuuw0GH8PQ2gKMi6CATks5q6Nc3gaJpZM4KnmDM .