search

PolymerElements / iron-menu-behavior

Accessible menu behavior
18 stars 28 forks source link

Disabled menu should not be in tab order #88

Closed hcarmona closed 7 years ago

hcarmona commented 7 years ago

This PR was created because of https://github.com/PolymerElements/paper-radio-group/pull/77

This change fixes an issue where an element that uses IronMenuBehavior will focus one of its disabled children if all children are disabled. See: http://crbug.com/642644

hcarmona commented 7 years ago

/cc @danbeam @notwaldorf @tjsavage

@bicknellr PTAL

danbeam commented 7 years ago

@bicknellr what's the status on this PR?

danbeam commented 7 years ago

you probably want to squash all the commits together though (up to @bicknellr)

hcarmona commented 7 years ago

Squashed all commits :-)

hcarmona commented 7 years ago

How do I land this PR?

bicknellr commented 7 years ago

LGTM2, thanks!