search

PolymerElements / iron-menu-behavior

Accessible menu behavior
18 stars 28 forks source link

Ignore keyEvent for modifier keys. That fixes search for values containing special symbols. #95

Closed Dor1s closed 7 years ago

Dor1s commented 7 years ago

@bicknellr, I would appreciate any feedback as well as some instructions on how to run the tests, since I'm not familiar with all these things :) Thanks!

bicknellr commented 7 years ago

To run the tests, grab the Polymer CLI, cd into the repo's root and install the dependencies with polymer install --variants, then run polymer test to test on all of the browsers that are available on your machine.

bicknellr commented 7 years ago

Also, if you have a Sauce Labs account, you can do this instead:

SAUCE_USERNAME=[your username] SAUCE_ACCESS_KEY=[your key] polymer test --sauce default

This should run with all of the setups defined by wct-sauce, which is what polymer test --sauce proxies to.

Dor1s commented 7 years ago

Thanks for the instructions regarding the tests. I don't have a Sauce Labs account, so trying to make it work via Polymer CLI.

Dor1s commented 7 years ago

It seems to be working:

$ polymer test -l chrome
Installing and starting Selenium server for local browsers
Selenium server running on port 44420
chrome 60 [1.x]          Beginning tests via http://localhost:8000/components/iron-menu-behavior/generated-index.html?cli_browser_id=1
chrome failed to maximize
chrome 60                Beginning tests via http://localhost:8081/components/iron-menu-behavior/generated-index.html?cli_browser_id=0
chrome failed to maximize
chrome 60 [1.x]          Tests passed
chrome 60                Tests passed
Test run ended with great success

chrome 60 (76/0/0)                      chrome 60 [1.x] (76/0/0)              

~/Projects/iron-menu-behavior$ polymer test -l firefox
Installing and starting Selenium server for local browsers
Selenium server running on port 38969
firefox 54               Beginning tests via http://localhost:8081/components/iron-menu-behavior/generated-index.html?cli_browser_id=0
firefox 54 [1.x]         Beginning tests via http://localhost:8000/components/iron-menu-behavior/generated-index.html?cli_browser_id=1
firefox failed to maximize
firefox failed to maximize
firefox 54 [1.x]         Tests passed
firefox 54               Tests passed
Test run ended with great success

firefox 54 (76/0/0)                     firefox 54 [1.x] (76/0/0)
bicknellr commented 7 years ago

Thanks!