PolymerElements / iron-overlay-behavior

Makes an element an overlay with an optional backdrop
41 stars 71 forks source link

Fix #269: TypeError: observerHandle is null in Firefox #270

Closed TrebuhD closed 6 years ago

TrebuhD commented 6 years ago

This fixes the linked issue, but I'm not 100% sure it won't break anything under the hood.

googlebot commented 6 years ago

Thanks for your pull request. t looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
TrebuhD commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

valdrinkoshi commented 6 years ago

I'll close this for now, as we're working with @TrebuhD to provide details on the bug in #269. The fix will require unit tests in order to avoid future regressions

TrebuhD commented 5 years ago

Maybe we should consider reopening this in light of the conversation over at https://github.com/PolymerElements/iron-overlay-behavior/issues/269 and quite a few people reporting being affected by this bug?