PolymerElements / iron-overlay-behavior

Makes an element an overlay with an optional backdrop
41 stars 71 forks source link

Make IronFocusablesHelper a singleton #289

Closed rictic closed 5 years ago

rictic commented 5 years ago

This is easier for closure compiler to read and optimize correctly, and is otherwise a no-op.

Similar to the change we made to the other helper in this repo.

Internalized as cl/218204453

rictic commented 5 years ago

Hm, what's your read of this weird test output? The internal tests all pass

e111077 commented 5 years ago

never seen those before. I'm rerunning

rictic commented 5 years ago

Thanks!