Fixes #57: `attr-for-selected` now always expects hyphenated names.

PolymerElements / iron-selector

Manages a list of elements that can be selected

32 stars 55 forks source link

Fixes #57: `attr-for-selected` now always expects hyphenated names. #101

Closed bicknellr closed 8 years ago

bicknellr commented 8 years ago

(fixes #57)

mgiuffrida commented 8 years ago

Can you be sure to mention this in the docs and release notes?

In JS, should attrForSelected be set to a hyphenated-attribute-name or camelCaseProperty?

bicknellr commented 8 years ago

@mgiuffrida This PR has a doc update here - let me know if it needs any clarification. Also, the expected input is the same (hyphenated) whether you're setting it as an inline attribute or by the setter. (This PR wasn't actively implemented to support that; Polymer, to my understanding, just doesn't treat properties with type: String differently when they're set as inline attributes vs through the setter.)

mgiuffrida commented 8 years ago

:+1:

bicknellr commented 8 years ago

Now I know if you force push a branch while the PR is closed you can't reopen... imgres-1

bicknellr commented 8 years ago

("reopened" as #109)