Allow selecting by a prop with zero value. Fixes #39.

PolymerElements / iron-selector

Manages a list of elements that can be selected

32 stars 55 forks source link

Allow selecting by a prop with zero value. Fixes #39. #102

Closed arthurevans closed 8 years ago

arthurevans commented 8 years ago

Also made the dom-repeat tests synchronous by replacing setTimeout with render calls. Took these tests from ~76ms to ~12ms.

arthurevans commented 8 years ago

Just noted that this will collide with @bicknellr's fix for another issue, #101.

bicknellr commented 8 years ago

Totally didn't notice this when writing #101! I get the feeling that this is a pretty common issue for JavaScript in general.

bicknellr commented 8 years ago

Also, this seems to fix #84.

mgiuffrida commented 8 years ago

Ah, the ol' (0 || '') == ''. Thanks Javascript.

Also, this seems to fix #84.

Confirmed, thanks!

arthurevans commented 8 years ago

Updated copyright on the new test file. Ping @cdata or current owner ...

bicknellr commented 8 years ago

LGTM. I spent some time messing around with nested templates in IE (edit: unrelated to this PR, btw) but couldn't get them to work; the tests passed here though..