search

PolymerElements / iron-selector

Manages a list of elements that can be selected
32 stars 55 forks source link

behavior doc update #12

Closed atotic closed 9 years ago

atotic commented 9 years ago

Behavior docs get visible with these changes.

cdata commented 9 years ago

Actually, I had to revoke my LGTM.

Can you try making the comment an HTML comment, but placing it immediately after the <link> tags in the page? I think the problem is that it has to appear before the script tag, not that it has to be inside the script.

atotic commented 9 years ago

They do not show up that way.

On Thu, May 14, 2015 at 2:24 PM, Christopher Joel notifications@github.com wrote:

Actually, I had to revoke my LGTM.

Can you try making the comment an HTML comment, but placing it immediately after the tags in the page? I think the problem is that it has to appear before the script tag, not that it has to be inside the script.

— Reply to this email directly or view it on GitHub https://github.com/PolymerElements/iron-selector/pull/12#issuecomment-102175347 .

atotic commented 9 years ago

HTML comments only work with dom-module

On Thu, May 14, 2015 at 2:49 PM, Aleks Totic a@totic.org wrote:

They do not show up that way.

On Thu, May 14, 2015 at 2:24 PM, Christopher Joel < notifications@github.com> wrote:

Actually, I had to revoke my LGTM.

Can you try making the comment an HTML comment, but placing it immediately after the tags in the page? I think the problem is that it has to appear before the script tag, not that it has to be inside the script.

— Reply to this email directly or view it on GitHub https://github.com/PolymerElements/iron-selector/pull/12#issuecomment-102175347 .