PolymerElements / iron-selector

Manages a list of elements that can be selected
32 stars 55 forks source link

add all required files - fixing #131 #132

Closed dotnetCarpenter closed 8 years ago

dotnetCarpenter commented 8 years ago

I also change the private field to false, since it makes no sense to have a public published project marked as private. - reverted back to true

Another issue is that the relative href expect a folder structure that is not given by the project (e.g. ../polymer/polymer.html). This is problematic but out of scope for this PR.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


dotnetCarpenter commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

notwaldorf commented 8 years ago

We keep private as false, so that the elements don't get published in the bower catalog -- this is because we can't currently guarantee nobody has taken any of the existing polymer element names, and would cause a bunch of confusion if they did.

dotnetCarpenter commented 8 years ago

@notwaldorf Seems that the check failed because of an issue with selenium not starting and not the tests.

dotnetCarpenter commented 8 years ago

@notwaldorf Should I force push to trigger a new travis test run?

notwaldorf commented 8 years ago

@dotnetCarpenter That's ok, I can do it!

notwaldorf commented 8 years ago

There seems to be a legit test failure, but I don't see how your commit would've caused that. @valdrinkoshi you looked at this recently -- are tests known to be grumpers?

notwaldorf commented 8 years ago

Gonna merge this in the meantime -- thanks!