Closed dotnetCarpenter closed 8 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
We keep private
as false, so that the elements don't get published in the bower
catalog -- this is because we can't currently guarantee nobody has taken any of the existing polymer element names, and would cause a bunch of confusion if they did.
@notwaldorf Seems that the check failed because of an issue with selenium not starting and not the tests.
@notwaldorf Should I force push to trigger a new travis test run?
@dotnetCarpenter That's ok, I can do it!
There seems to be a legit test failure, but I don't see how your commit would've caused that. @valdrinkoshi you looked at this recently -- are tests known to be grumpers?
Gonna merge this in the meantime -- thanks!
I also change the- reverted back to trueprivate
field to false, since it makes no sense to have a public published project marked as private.Another issue is that the relative href expect a folder structure that is not given by the project (e.g.
../polymer/polymer.html
). This is problematic but out of scope for this PR.