PolymerElements / iron-selector

Manages a list of elements that can be selected
32 stars 55 forks source link

Duplicate API: selectedAttribute and attributeForSelected #32

Closed ebidel closed 9 years ago

ebidel commented 9 years ago

Do these two properties do the same thing?

selectedAttribute https://github.com/PolymerElements/iron-selector/blob/master/iron-selectable.html#L96

attributeForSelected https://github.com/PolymerElements/iron-selector/blob/master/iron-selectable.html#L27

Preferably, we should keep the first been around since the 0.5 days.

notwaldorf commented 9 years ago

I don't think they are the same thing (and the comments for each confirm this). Paper-radio-group uses both:

ebidel commented 9 years ago

Thanks for clarifying. I think some my confusion is because 0.5's selectedAttribute was attrForSelected'd semantics. That is IIRC, 0.5's selectedAttribute didn't add the attribute to the selected element, it just looked for that attr to make a selection. Closing