search

PolymerElements / iron-selector

Manages a list of elements that can be selected
32 stars 55 forks source link

Fix issues multiselect #48

Closed Trakkasure closed 8 years ago

Trakkasure commented 9 years ago

This resolves issues noted in:

44

43

33

30

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

googlebot commented 9 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

Trakkasure commented 9 years ago

I signed it!

On Sat, Jul 25, 2015 at 3:58 AM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

— Reply to this email directly or view it on GitHub https://github.com/PolymerElements/iron-selector/pull/48#issuecomment-124822882 .

googlebot commented 9 years ago

CLAs look good, thanks!

danopia commented 9 years ago

I just upgraded 0.5 => 1.0 and struggled for hours trying to databind selectedValues correctly. My singular lists were working, but nothing would make the multi-lists update when the user selected something.

This patchset fixes my problems so it would be great if this (or a similar PR) got merged so I don't have to store a polymer patch in my repo

Tanbouz commented 9 years ago

Fixes include iron-selectable for issue #30 ?

Trakkasure commented 9 years ago

@Tanbouz Indeed after looking closer, I did find the issue that was causing this one. I added one more for #30 after fully testing the example.

Trakkasure commented 9 years ago

All of these fixes are available on my working_production branch until such time as they are merged into the main code in this main repo.

cdata commented 9 years ago

Thanks for the contribution! It is looking pretty good. I noticed that you are marking several issues as resolved, but the change does not include any testing that might catch regressions in the future. Would you please consider adding such tests?

Trakkasure commented 9 years ago

Absolutely. I'll add tests.

cdata commented 8 years ago

@Trakkasure FYI I am going to fork this and add relevant tests. Thanks again for the contribution.

cdata commented 8 years ago

Merged these changes with #68 .