PolymerElements / iron-selector

Manages a list of elements that can be selected
32 stars 55 forks source link

Wait until the first item to be setted before set the other item #59

Closed taurafigueiredo closed 8 years ago

taurafigueiredo commented 9 years ago

It solves a 'paper-drawer-panel' animation issue on old smartphones caused by two animations occurring simultaneously.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


taurafigueiredo commented 9 years ago

I signed it!

2015-09-10 1:58 GMT-03:00 googlebot notifications@github.com:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

— Reply to this email directly or view it on GitHub https://github.com/PolymerElements/iron-selector/pull/59#issuecomment-139117428 .

googlebot commented 9 years ago

CLAs look good, thanks!

addyosmani commented 9 years ago

Could you provide an example of a device/OS where this patch is currently required? The current changelist requires code-style fixes, but it would be useful to verify where this is breaking first :pineapple:

bicknellr commented 8 years ago

I'm going to close this one since it's been a while.

@taurafigueiredo If this is still affecting you, could you open an issue with a reproducible test case and link back to this PR? I'm also a bit confused as to what's going on here; this looks like a hack for a problem higher up in the stack. Maybe the issue is really in paper-drawer-panel?