PolymerElements / iron-selector

Manages a list of elements that can be selected
32 stars 55 forks source link

Hygeinic listener toggling #70

Closed cdata closed 8 years ago

cdata commented 8 years ago

This is an alternative design to #64, and will minimize listen / unlisten thrashing.

https://github.com/Polymer/polymer/pull/2535 will eventually give us better core tools to handle this kind of scenario. In the mean time, we will do our own book keeping.

/cc @ronnyroeller @johnheroy @azakus

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

notwaldorf commented 8 years ago

LGTM! Can't wait for #2535 to be fixed because this is pretty gory :)

johnheroy commented 8 years ago

thank you!