PolymerElements / iron-selector

Manages a list of elements that can be selected
32 stars 55 forks source link

Observe nodes #73

Closed cdata closed 8 years ago

cdata commented 8 years ago

This change does the following:

/cc @notwaldorf

This branch is blocked by https://github.com/Polymer/polymer/pull/2548 being tagged. It is currently released on polymer#master, but until it is tagged these changes cannot be merged into iron-selected#master.

cdata commented 8 years ago

/cc @azakus

sorvell commented 8 years ago

Can we add a test that would have failed before? For example, add a node that only gets to distributed to a child of the selector via re-projection?

sorvell commented 8 years ago

Why don't we change the items property so that it's only calculated when we get a signal that the items may have changed (startup + when observedNodes tells you).

cdata commented 8 years ago

Feedback addressed. Tests are failing locally due to a bug in observeNodes, reported offline to @sorvell

cdata commented 8 years ago

Also, I threw in a fix for #69 since it was relevant and it felt lame to fix it with the old code.

cdata commented 8 years ago

add a node that only gets to distributed to a child of the selector via re-projection?

We already appear to have tests for this that passed. See: https://github.com/PolymerElements/iron-selector/blob/master/test/content.html

Hrm..

cdata commented 8 years ago

Already resolved, but this change now depends on resolution of https://github.com/Polymer/polymer/issues/2587

notwaldorf commented 8 years ago

Just a note for future @cdata: You'll need to bump the Polymer version up in bower.json to 1.2.0