Closed reinert closed 8 years ago
Thanks for sending this PR; awesome tests! PTAL at the comments.
Sorry for the delay. It's been a while and I needed to schedule a time to review it.
Thanks for appreciating the PR. I tried to follow your recommendations, except the first, which I stuck to the pattern already present at the code.
If you feel the bind is really beneficial to the code, I can change it too.
Thanks for your time.
Using MockInteractions on tests broke the patch. Some exception is occurring. Locally in my machine it is working fine. Do you know any reason why is that?
Checking master code, I saw sometimes using CustomEvent, other MockInteractions.
The difference is that MockInteractions is always used wrapping the source element with Polymer like MockInteractions.tap(Polymer.dom(s).children[0])
. Is that trick mandatory?
Oh! After merging locally this patch with master I realized this failure is already present on master. So it's not an issue here.
Left a comment. Also, #108 should fix the test, so once that's in you'll need to rebase to see it reflected here.
Done.
LGTM, thanks again!
Thanks for reviewing the PR. You guys are doing an amazing job with the polymer project. My codes were never so beautiful. I'm definitely in love with it.
:)
Fixes #75