PolymerElements / iron-selector

Manages a list of elements that can be selected
32 stars 55 forks source link

1.0.8 release dependency issues #79

Closed ecoutu closed 8 years ago

ecoutu commented 8 years ago

1.0.8 release relies on new features in polymer 1.2.0, making it non-backwards compatible, as a result, this patch number release is breaking dependencies in bower.

I suggest a minor release 1.2.0 for iron-selector.

bicknellr commented 8 years ago

Woah, yeah, you're totally right.

bicknellr commented 8 years ago

This bug is months old! :scream:

bicknellr commented 8 years ago

$ git diff v1.0.7 origin/master bower.json

diff --git a/bower.json b/bower.json
index ff00842..665805d 100755
--- a/bower.json
+++ b/bower.json
@@ -1,12 +1,10 @@
 {
   "name": "iron-selector",
-  "version": "1.0.7",
+  "version": "1.0.8",
   "description": "Manages a set of elements that can be selected",
   "private": true,
   "license": "http://polymer.github.io/LICENSE.txt",
-  "main": [
-    "iron-selector.html"
-  ],
+  "main": "iron-selector.html",
   "authors": [
     "The Polymer Authors"
   ],
@@ -22,14 +20,14 @@
   "homepage": "https://github.com/PolymerElements/iron-selector",
   "ignore": [],
   "dependencies": {
-    "polymer": "Polymer/polymer#^1.0.0"
+    "polymer": "Polymer/polymer#^1.2.0"
   },
   "devDependencies": {
     "iron-component-page": "PolymerElements/iron-component-page#^1.0.0",
     "iron-test-helpers": "polymerelements/iron-test-helpers#^1.0.0",
     "paper-styles": "PolymerElements/paper-styles#^1.0.4",
     "test-fixture": "PolymerElements/test-fixture#^1.0.0",
-    "web-component-tester": "*",
+    "web-component-tester": "^4.0.0",
     "webcomponentsjs": "webcomponents/webcomponentsjs#^0.7.0"
   }
 }
bicknellr commented 8 years ago

No crazy changes since the last (version broken) release, so I'm going to bump and call this good: $ git diff v1.0.8 origin/master *.html demo/*.html test/*.html

diff --git a/iron-multi-selectable.html b/iron-multi-selectable.html
index 906e920..69c30a7 100644
--- a/iron-multi-selectable.html
+++ b/iron-multi-selectable.html
@@ -54,7 +54,7 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
      * `value` will be toggled; otherwise the `value` will be selected.
      *
      * @method select
-     * @param {string} value the value to select.
+     * @param {string|number} value the value to select.
      */
     select: function(value) {
       if (this.multi) {
diff --git a/iron-selectable.html b/iron-selectable.html
index 403a759..6c751a9 100644
--- a/iron-selectable.html
+++ b/iron-selectable.html
@@ -56,6 +56,7 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN

       /**
        * Gets or sets the selected element. The default is to use the index of the item.
+       * @type {string|number}
        */
       selected: {
         type: String,
@@ -173,7 +174,7 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
      * Selects the given value.
      *
      * @method select
-     * @param {string} value the value to select.
+     * @param {string|number} value the value to select.
      */
     select: function(value) {
       this.selected = value;
bicknellr commented 8 years ago

Bumped to v1.1.0.