Closed graeme44 closed 8 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
Thanks for the PR! This needs to be implemented in IronMultiSelectableBehavior
+ tested.
.. also rebased apparently? Weird for such a self-contained PR.
@graeme44, you there? Just wanted to give you a heads up that I'm going take over adding this feature soon - probably before the end of the week. If you'd prefer to keep maintaining this PR, please leave a comment.
@bicknellr, that sounds good! I'm happy for you to take over.
Ok, I just created a new branch, issue-87, pointing to the same commit as current master. Could you rebase and change the base branch for this PR to that so that I can pull your commits into it?
@bicknellr, Rebase done.
@graeme44, just one more step: could you open a new PR with 'issue-87' as the base branch? I thought there was a way to change this on an open a PR but some quick searching seems to imply otherwise.
Oh, forgot to close this after merging #110.
This closes #87.