PolymerElements / iron-selector

Manages a list of elements that can be selected
32 stars 55 forks source link

Allows selected to be set using index, even if attr-for-selected is used #88

Closed graeme44 closed 8 years ago

graeme44 commented 8 years ago

This closes #87.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


graeme44 commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

bicknellr commented 8 years ago

Thanks for the PR! This needs to be implemented in IronMultiSelectableBehavior + tested.

bicknellr commented 8 years ago

.. also rebased apparently? Weird for such a self-contained PR.

bicknellr commented 8 years ago

@graeme44, you there? Just wanted to give you a heads up that I'm going take over adding this feature soon - probably before the end of the week. If you'd prefer to keep maintaining this PR, please leave a comment.

graeme44 commented 8 years ago

@bicknellr, that sounds good! I'm happy for you to take over.

bicknellr commented 8 years ago

Ok, I just created a new branch, issue-87, pointing to the same commit as current master. Could you rebase and change the base branch for this PR to that so that I can pull your commits into it?

graeme44 commented 8 years ago

@bicknellr, Rebase done.

bicknellr commented 8 years ago

@graeme44, just one more step: could you open a new PR with 'issue-87' as the base branch? I thought there was a way to change this on an open a PR but some quick searching seems to imply otherwise.

bicknellr commented 8 years ago

Oh, forgot to close this after merging #110.