PolymerElements / iron-selector

Manages a list of elements that can be selected
32 stars 55 forks source link

iron-selector.items is not changed during "iron-items-changed" event fired #90

Closed sgoryachkin closed 8 years ago

sgoryachkin commented 8 years ago

this._updateItems() and this.fire('iron-items-changed', ...) are swaped in _observeItems

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


sgoryachkin commented 8 years ago

Bug https://github.com/PolymerElements/iron-selector/issues/89

sgoryachkin commented 8 years ago

I signed it 27 нояб. 2015 г. 9:44 PM пользователь "googlebot" notifications@github.com написал:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

— Reply to this email directly or view it on GitHub https://github.com/PolymerElements/iron-selector/pull/90#issuecomment-160187823 .

googlebot commented 8 years ago

CLAs look good, thanks!

MeTaNoV commented 8 years ago

by reviewing the code, I agree that the event should be fired after the updateItems call

bicknellr commented 8 years ago

Could you add a test or two? Regressions are no fun. Otherwise, LGTM.

sgoryachkin commented 8 years ago

Ok. I will try in the near future to add test

sgoryachkin commented 8 years ago

This issue was fixed in pull request: https://github.com/PolymerElements/iron-selector/pull/100

bicknellr commented 8 years ago

Great, thanks for pointing that out!