Closed sgoryachkin closed 8 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it 27 нояб. 2015 г. 9:44 PM пользователь "googlebot" notifications@github.com написал:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
- If you signed the CLA as a corporation, please let us know the company's name.
— Reply to this email directly or view it on GitHub https://github.com/PolymerElements/iron-selector/pull/90#issuecomment-160187823 .
CLAs look good, thanks!
by reviewing the code, I agree that the event should be fired after the updateItems call
Could you add a test or two? Regressions are no fun. Otherwise, LGTM.
Ok. I will try in the near future to add test
This issue was fixed in pull request: https://github.com/PolymerElements/iron-selector/pull/100
Great, thanks for pointing that out!
this._updateItems() and this.fire('iron-items-changed', ...) are swaped in _observeItems