Open brad4d opened 7 years ago
This is an offshoot of #85
test-helpers.js and other files use a complicated pass-global-and-scope-object-to-an-iife method of defining things in an effort to support both some complex loading situations and closure-compiler compilation.
An explanation and understandable emotional reaction may be found here. https://github.com/PolymerElements/iron-test-helpers/pull/69
As a member of the closure-compiler team, I'd like to suggest that you just use window.foo = ... to define your globals. My rationale is this:
window.foo = ...
window
this
This is an offshoot of #85
test-helpers.js and other files use a complicated pass-global-and-scope-object-to-an-iife method of defining things in an effort to support both some complex loading situations and closure-compiler compilation.
An explanation and understandable emotional reaction may be found here. https://github.com/PolymerElements/iron-test-helpers/pull/69
As a member of the closure-compiler team, I'd like to suggest that you just use
window.foo = ...
to define your globals. My rationale is this:window
is always available.window
in lots of the implementations anyway.this
isn't even defined in global scope.