PolymerElements / iron-test-helpers

Utility classes to make testing easier
26 stars 25 forks source link

Added wrapper function for mouseover, mouseenter, and mouseleave #91

Closed QuiWorks closed 6 years ago

QuiWorks commented 6 years ago

Fixes #90, fixes #65 by creating three new functions mouseenter(node, xy), mouseleave(node, xy), and mouseover(node, xy) that wrap the makeMouseEvent(eventName, xy, node) function.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


QuiWorks commented 6 years ago

I signed it.

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot commented 6 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

ghost commented 6 years ago

Hey I'm the same person as QuiWorks just a different account. I don't know how this account got associated with these changes, but I signed the agreement with this account.