PolymerElements / neon-animation

Polymer + Web Animations
https://www.webcomponents.org/element/PolymerElements/neon-animation
143 stars 98 forks source link

Cannot assign to read only property 'target' of object '#<AnimationPlaybackEvent>' #229

Closed govis closed 7 years ago

govis commented 7 years ago

Description

All Demos yield a Cannot assign to read only property 'target' of object '#<AnimationPlaybackEvent>' error coming from https://github.com/web-animations/web-animations-js/blob/master/src/web-animations-next-animation.js#L223

neon-animation v2.0.0 (2.0-preview) web-animations-js v2.2.3 polymer v2.0.0-rc.4 webcomponentsjs v1.0.0-rc.8

Expected outcome

No errors

Actual outcome

Cannot assign to read only property 'target' of object '#'" error

Live Demo

Run any of the demos:

image

Browsers Affected

govis commented 7 years ago

Looks like it has something to do with the 2.2.3 commit in web-animations/web-animations-js: https://github.com/web-animations/web-animations-js/issues/123

krumware commented 7 years ago

Getting the same issue over here. neon-animation references web-animations-js version 2.2.0, but version 2.2.3 is the actual version being pulled. 2.2.0 is not an available release tag in web-animations-js https://github.com/web-animations/web-animations-js/releases

krumware commented 7 years ago

Also, I wanted to clarify, the issue here references Polymer 2.0+, but we are seeing the same issue on Polymer 1.8.1

krumware commented 7 years ago

our temporary fix was to add the following to our app's bower.json "web-animations-js": "web-animations/web-animations-js#2.2.2"

fungusamongus commented 7 years ago

We also had this problem in one of our polymer projects and fixed it by setting the specific 2.2.2 tag in our bower. This is with Polymer 1.8.1

samuelli commented 7 years ago

Just to keep everyone in the loop. I'm trying to get this fixed upstream in web-animations. If that doesn't resolve in the next few hours, we'll go with this stop-gap solution in #230

krumware commented 7 years ago

Thanks Sam!

On Apr 13, 2017 5:30 PM, "Sam Li" notifications@github.com wrote:

Just to keep everyone in the loop. I'm trying to get this fixed upstream in web-animations. If that doesn't resolve in the next few hours, we'll go with this stop-gap solution in #230 https://github.com/PolymerElements/neon-animation/pull/230

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PolymerElements/neon-animation/issues/229#issuecomment-294026840, or mute the thread https://github.com/notifications/unsubscribe-auth/AQgI5o-xVlY2ugBs-ikl2OPyCVm1CKmPks5rvpPsgaJpZM4M8y8E .

samuelli commented 7 years ago

Thanks for your patience. This has been fixed upstream in https://github.com/web-animations/web-animations-js/pull/124. Please update to v2.2.4 for web-animations-js and the issue should be resolved.