material design spec audit - few changes needed

PolymerElements / paper-button

A button à la Material Design

https://www.webcomponents.org/element/PolymerElements/paper-button

138 stars 64 forks source link

material design spec audit - few changes needed #12

Closed tjsavage closed 9 years ago

tjsavage commented 9 years ago

Typography seems like it might be off - font too large and/or not the right roboto? This might just be in the demo but should be right.
Pressed state might have to be a little higher.
Decision handed down from design: button should NOT stay focused after press, unless it was focused prior to press.
Pressed state height should be 2x the focus state height. We should exaggerate both if needed for a11y.

blasten commented 9 years ago

It's mostly fixed except for _"... button should NOT stay focused after press"_ The main reason is that after press, the button is automatically focused. As far as I know, this is the default behavior of most controls. Once tapped, the focus is transferred. Correct me if I'm wrong @cdata.

cdata commented 9 years ago

@tjsavage @blasten To be clear, design is referring to the focus visual, not the actual state of being focused, correct? If so, this should be easy to change for everything in https://github.com/PolymerElements/iron-behaviors.

blasten commented 9 years ago

all should be fixed now!