PolymerElements / paper-button

A button à la Material Design
https://www.webcomponents.org/element/PolymerElements/paper-button
138 stars 64 forks source link

Fix for document.createElement('paper-button') DOMException #145

Closed jaichandra closed 7 years ago

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


jaichandra commented 7 years ago

I signed the CLA.

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented 7 years ago

CLAs look good, thanks!

jaichandra commented 7 years ago

@lychyi My code is now broken due to the changes in 2.0 branch. Will refactor and check. but yeah.. as per docs, for legacy elements it should be attached. Demo works with attached.

jaichandra commented 7 years ago

attached works.

lychyi commented 7 years ago

Fantastic @jaichandra nice work! Everything looks good on my end. Hopefully the team can get this merged soon. I ran into this when extending paper-button with the new 2.0 class syntax and it caused quite a headache.

notwaldorf commented 7 years ago

This is no longer needed, since we're not putting the paper-material class on the host anymore