PolymerElements / paper-button

A button à la Material Design
https://www.webcomponents.org/element/PolymerElements/paper-button
138 stars 64 forks source link

Make disabled flat button consistent with enabled. #180

Closed vukisoft closed 5 years ago

vukisoft commented 5 years ago

While enabled flat (not raised) button has no background, disabled version does which is inconsistent and looks bad. Change adds background for raised disabled buttons only.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
vukisoft commented 5 years ago

I signed it!

On Thu, 26 Jul 2018 02:56:55 -0700, googlebot wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝PLEASE VISIT TO SIGN.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

WHAT TO DO IF YOU ALREADY SIGNED THE CLA

INDIVIDUAL SIGNERS

* It's possible we don't

have your GitHub username or you're using a different email address on your commit. Check your existing CLA data [1] and verify that your email is set on your git commits [2].

CORPORATE SIGNERS

* Your company has

a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot [3] (Public version [4]).

-- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [8], or mute the thread [9].

Links:

[1] https://cla.developers.google.com/clas [2] https://help.github.com/articles/setting-your-email-in-git/ [3] http://go/cla#troubleshoot [4] https://opensource.google.com/docs/cla/#troubleshoot [5] https://cla.developers.google.com/clas [6] https://help.github.com/articles/setting-your-email-in-git/ [7] https://github.com/settings/emails [8] https://github.com/PolymerElements/paper-button/pull/180#issuecomment-408044534 [9] https://github.com/notifications/unsubscribe-auth/APxlzTAkWXDtb28eZ3-C-c4WvtBIqThoks5uKZJngaJpZM4Vhhfp

googlebot commented 5 years ago

CLAs look good, thanks!