search

PolymerElements / paper-button

A button à la Material Design
https://www.webcomponents.org/element/PolymerElements/paper-button
138 stars 64 forks source link

Add 'is' to paper-button #2

Closed jklein24 closed 9 years ago

cdata commented 9 years ago

@garlicnation @jklein24 with complete respect and acknowledgement towards how frustrating it would be from a tooling perspective if elements didn't have is on them, @sjmiles would like us to debate the various merits before removing this.

cdata commented 9 years ago

Also, there was a typo that raises a syntax error: missing closing quotation mark on the string :(

cdata commented 9 years ago

(the irony here is that if we were running the compiler pass as part of our tests, we would have caught that).

jklein24 commented 9 years ago

Sorry about the syntax error!! I'm happy to talk this through with Scott because it breaks the compiled use case in a couple different ways. The good news is that the compiler pass did catch this error:

ERROR - Parse error. Unterminated string literal is: 'paper-button,

jklein24 commented 9 years ago

@sjmiles, can we hash this out? It's currently breaking use of paper-button inside Google and Chrome.