search

PolymerElements / paper-button

A button à la Material Design
https://www.webcomponents.org/element/PolymerElements/paper-button
138 stars 64 forks source link

Update to Polymer 1.1 #45

Closed abdonrd closed 9 years ago

notwaldorf commented 9 years ago

@abdonrd The webcomponents js version is still incorrect, but i think everything else looks fine. Please also squash your commits :)

abdonrd commented 9 years ago

Received! I thought I should also maintain the webcomponents.js version.

Sorry, squash my commits?

abdonrd commented 9 years ago

Updated!

The same with PolymerElements/paper-input#146 and PolymerElements/paper-toggle-button#36.

notwaldorf commented 9 years ago

:) Squashing commits means merging them all into one commit: https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

abdonrd commented 9 years ago

Yes, I squash the commits with the updates in the PRs.

But... You said one commit for all the PR? That way we lose the flow of evolution, no?

notwaldorf commented 9 years ago

We prefer to have one commit per PR, and the PR to be small and descriptive enough that the individual commits don't matter as much.

abdonrd commented 9 years ago

Okey @notwaldorf! I will update now the PRs.

abdonrd commented 9 years ago

Updated with only one commit! :)

notwaldorf commented 9 years ago

Thanks so much! :+1: