PolymerElements / paper-button

A button à la Material Design
https://www.webcomponents.org/element/PolymerElements/paper-button
138 stars 64 forks source link

Move template back down to after the style tag. #46

Closed mrdewitt closed 9 years ago

mrdewitt commented 9 years ago

Fixes a bug in Shady DOM only that causes unexpected behavior of the ripple. (see demo page in Chrome):

image

Also looks like the button text is no longer capitalized.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


mrdewitt commented 9 years ago

I wonder if there is actually a dependency problem, because the commit that introduced this referenced Polymer 1.1 styles.

abdonrd commented 9 years ago

I haven't this problem. Try to remove the bower_components folder and repeat the bower install.

mrdewitt commented 9 years ago

Thanks for the advice, that problem is no longer occurring for me.