Closed abdonrd closed 8 years ago
paper-ripple
is used and is dynamically created by PaperRippleBehavior
@keanulee Yes, but the paper-button-behavior.html
imports the paper-ripple-behavior.html
that imports the paper-ripple.html
. :)
Yes, but paper-behavior's bower.json
lists paper-ripple as a dev dependency. I guess the HTML import isn't technically needed in paper-button.html though.
@keanulee I understand!
Now I've done the following:
bower_components
.bower i
polyserve
And the demo works fine, with the ripple.
@abdonrd If you bower install --production
though, you'll see the paper-ripple is not included. The reason why paper-ripple
was included is because (at least) one of the dev dependency is included the latest released version of paper-button
, which includes paper-ripple
@keanulee oh! Now I understand much better. Thanks!
Then... The right thing would be that paper-behaviors
include paper-ripple
as dependencies
instead of devDependencies
. Right?
@abdonrd Yes, paper-ripple
should be a dependency of paper-behaviors
- it has an HTML import for it too (https://github.com/PolymerElements/paper-behaviors/blob/master/paper-ripple-behavior.html#L12). Mind sending a PR for that, and we'll revisit this once that's been done and released?
@keanulee sure! We can fix it! :muscle:
@keanulee now we can open and merge this? :smiley:
I can't reopen this PR because GitHub won't let me ("The remove_unused_import branch was force-pushed or recreated"). Feel free to submit a new PR.
Also, change
polymerelements
toPolymerElements