PolymerElements / paper-button

A button à la Material Design
https://www.webcomponents.org/element/PolymerElements/paper-button
138 stars 64 forks source link

Non-standard code: Javascript code in the <script> tag is showing up after the end of the </dom-module> tag #88

Closed cherukumilli closed 8 years ago

cherukumilli commented 8 years ago

paper-button's code is not following the same standards as other elements. paper-button's javascript code is in the tag but this before the

Current paper-button code:

...
<dom-module>
   ...
</dom-module>
<script>
   ...
</script>

Expected:

...
<dom-module>
   ...
   <script>
      ...
   </script>
</dom-module>
keanulee commented 8 years ago

Hi @cherukumilli,

Thanks for letting us know. Would you mind creating a PR for this?

abdonrd commented 8 years ago

PR: https://github.com/PolymerElements/paper-button/pull/93

keanulee commented 8 years ago

Thanks @abdonrd