search

PolymerElements / paper-button

A button à la Material Design
https://www.webcomponents.org/element/PolymerElements/paper-button
138 stars 64 forks source link

Paper-button doesn't use a proper font style #94

Closed jhrdina closed 8 years ago

jhrdina commented 8 years ago

I feel like paper-button should use paper-styles/typography.html and its --paper-font-button mixin for font.

Expected outcome

Paper button uses 14px font with font-weight: 500 (Roboto Medium) as mentioned in Google Design Spec's Typography section and is already defined in paper-styles/typography.html.

after

_Image: material-design-lite demo, their CSS implementation here_

Actual outcome

Paper button uses default font size with default font-weight (400 - Roboto Regular).

before

Image: paper-card demo

abdonrd commented 8 years ago

:+1:

abdonrd commented 8 years ago

PR about this: https://github.com/PolymerElements/paper-button/pull/96

blasten commented 8 years ago

cc @notwaldorf

keanulee commented 8 years ago

We decided not to do this for a11y reasons - see https://github.com/PolymerElements/paper-button/issues/95#issuecomment-176444072