search

PolymerElements / paper-button

A button à la Material Design
https://www.webcomponents.org/element/PolymerElements/paper-button
138 stars 64 forks source link

:host > ::content * selector doesn't make sense #99

Closed esprehn closed 8 years ago

esprehn commented 8 years ago

there's only one <content> in the shadow root, and it's always a child of the host for matching, so this doesn't really make sense, why not just write ::content * ? Also note that Shadow DOM v1 will not allow a descendant selector like this. I'm not sure what this code was trying to do, but in v1 the best you could do is ::slotted(*) I think which is only ::content > * and doesn't deeply style slotted nodes.

esprehn commented 8 years ago

More importantly, what is this code trying to do?

keanulee commented 8 years ago

Hi @esprehn

Seems like this rule is not really needed (probably legacy code). Mind sending a PR to remove this? Thanks.

notwaldorf commented 8 years ago

Heh, I don't think @esprehn will send a PR; somebody else should take care of it :)