search

PolymerElements / paper-card

A Material Design piece of paper with unique related data
https://www.webcomponents.org/element/PolymerElements/paper-card
98 stars 62 forks source link

Expose sizing and position properties from iron-image (update) #92

Open matthewpull opened 7 years ago

matthewpull commented 7 years ago

Fixes #60

PR #62 also fixes this issue, but is a year old. This PR is an attempt to gain traction on fixing the issue and includes the two test cases required.

This is my first PR :tada:, so if I have made a rookie mistake or missed anything please let me know and I'll fix my error.

Cheers!

notwaldorf commented 7 years ago

Omg, finally looking at this. Sorry about that! @bicknellr for a double check, but this looks okay to me.

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

Pupix commented 5 years ago

Is this going to get merged anytime soon?