search

PolymerElements / paper-dialog-behavior

Makes an element a Material Design dialog
18 stars 22 forks source link

handle margin in --paper-dialog-title #119

Closed valdrinkoshi closed 6 years ago

valdrinkoshi commented 6 years ago

Fixes #118 by re-applying the mixin for h2 so that margin-top and margin-bottom can be overridden via the mixin. Here the repro showed in #118 with this fix applied https://jsbin.com/pitiqag/1/edit?html,output

Note that this doesn't fix the case where the mixin sets margin, e.g.

#dialog {
  --paper-dialog-title: {
    margin: 0
  }
}
valdrinkoshi commented 6 years ago

Will merge & test against master 👌