PolymerElements / paper-dialog-scrollable

A scrollable area used in a Material Design dialog
15 stars 18 forks source link

Absolute elements calculating position/height based on host instead of scrolling div #49

Closed pengying closed 8 years ago

pengying commented 8 years ago

Description

Expected: Absolute element calculates position/height relative to inner div:

screen shot 2016-04-11 at 6 33 23 pm

Actual: Absolute element calculate position/height relative to paper-dialog-scrollable

screen shot 2016-04-11 at 6 31 55 pm

Live Demo

N/A

Steps to reproduce

Add position:relative to #scrollable

Browsers Affected

valdrinkoshi commented 8 years ago

@pengying in this test I don't see the issue you describe http://jsbin.com/bibisey/2/edit?html,output Can you provide an example showing the issue?

pengying commented 8 years ago

Yeah it's actually not modifying the size of the dialog, it's overflowing it.

Whoa that's how you get elements working in jsbin. http://jsbin.com/fiforizijo/edit?html,output

valdrinkoshi commented 8 years ago

@pengying all you need is apply the mixin :) http://jsbin.com/pugukiw/2/edit?html,output I think your use case is specific (not everyone sets content to position: absolute), so there's no need for .scrollable to have position: relative. Closing this

pengying commented 8 years ago

Ah yeah you're right.