search

PolymerElements / paper-dialog-scrollable

A scrollable area used in a Material Design dialog
15 stars 18 forks source link

fixed ensure target #65

Closed fincha closed 7 years ago

fincha commented 7 years ago

fix for #63

valdrinkoshi commented 7 years ago

This would work only in Shady DOM, not with native Shadow DOM. The proper way to support this would be to either support dynamic changes of dialogElement (meaning have an observer and update accordingly to new and old value) or traverse the parents until we find a good dialog element candidate.

fincha commented 7 years ago

@valdrinkoshi one of my colleges suggested to use this.async, that do you with, will this solve this problem?

valdrinkoshi commented 7 years ago

I think we need an observer for changes of dialogElement, and ensure we have a value for dialogElement on attached. I'll open a new PR to address this 👌

valdrinkoshi commented 7 years ago

Fixing this in #69, added tests too 👌