PolymerElements / paper-dialog

A Material Design dialog

https://www.webcomponents.org/element/PolymerElements/paper-dialog

63 stars 41 forks source link

There is a problem with the dependency version #156

Open zaclummys opened 7 years ago

zaclummys commented 7 years ago

I know the component neon-animation is deprecated, but there are still some next-generation components (v3.0.0) that are depending on that.

when I try to install paper-dialog, Yarn throws a warning:

Couldn't find any versions for polymer/neon-animation that matches "^3.0.0-pre.1"

valdrinkoshi commented 7 years ago

paper-dialog dependency is on neon-animation 1.0.0 up to 2.x (see bower.json) It must be some other component trying to load a non-existent version of neon-animation

valpackett commented 7 years ago

uhhh https://github.com/PolymerElements/paper-dialog/blob/d05e06b9b245b4687559b8e8981c26c6e6e7a8d3/package.json#L21

modulizer added it automatically

valdrinkoshi commented 7 years ago

oh, good catch @myfreeweb! 👌 package.json was generated through polymer-modulizer, maybe @rictic or @e111077 can help on this?

valpackett commented 7 years ago

It's still used in the element code as well. No one touched anything after the modulizer here, it seems.

The 3.0 preview has been out since late August and paper-dialog is still broken on it :(

homerjonathan commented 6 years ago

My Pull Request fixes the neon-animation issue. Will this help resolve this issue.

e111077 commented 6 years ago

160

e111077 commented 6 years ago

I'm still looking into the npm issue, but @valdrinkoshi I think The PR linked above is the correct way to go.

@homerjonathan your PR will unfortunately be delayed by internal google testing to check for any breaks / bugs