PolymerElements / paper-drawer-panel

A Material Design two-section responsive panel
https://www.webcomponents.org/element/PolymerElements/paper-drawer-panel
25 stars 42 forks source link

Fixes#149 #158

Closed t-soares closed 7 years ago

t-soares commented 7 years ago

Fixes issue #149.

Reproduce the issue:

  1. https://jsfiddle.net/thisoares/0910ac0y/
  2. Click on the "Open Right Drawer" button. The drawer will appear from the left.

Solution: Disabled the drawer transition and enable it only on opening/closing the drawer.

Run the fix: https://jsfiddle.net/thisoares/rdjxmax4/ @blasten @minhlong139

blasten commented 7 years ago

@thisoares thanks for the update. A few tests are failing. Probably those assertions need to go inside a rAF callback.

t-soares commented 7 years ago

I agree that it is bad for performance. I changed the proposed solution. Instead of disabling the transition when changing the rightDrawer attribute, I disabled the drawer transition and enable it only when opening/closing the drawer. Thanks @blasten .

blasten commented 7 years ago

LGTM. Thanks!