search

PolymerElements / paper-drawer-panel

A Material Design two-section responsive panel
https://www.webcomponents.org/element/PolymerElements/paper-drawer-panel
25 stars 42 forks source link

Fixes issue #159 #161

Closed t-soares closed 2 years ago

t-soares commented 7 years ago

Fixes the issue #159.

Reproduce the issue:

  1. https://jsfiddle.net/10wprwvr/
  2. Click on the "Open Right Drawer" button.
  3. Close the drawer.
  4. Swipe from the right edge.
  5. The drawer is animated twice.

The PR #158 changed the drawer opening and closing to be done inside a requestAnimationFrame. At the end of a swipe movement, the width is reset outside the rAF block, causing the opening/closing animation to be started from the initial position.

Solution: Reset the drawer width inside the rAF Block that open or closes the drawer. It also restores the transition on the start and stop of edge peek.

Run the fix: https://jsfiddle.net/rdjxmax4/4/ @rubenstolk @blasten

jptrainor commented 7 years ago

I'm experiencing the same issue in iOS/WkWebview. Waiting on this to be merged and new paper-drawer-panel release tagged. Thanks.

rubenstolk commented 7 years ago

Why is this not being merged, #159 is a really serious bug imho...

t-soares commented 7 years ago

@blasten Can you take a look on this?

blasten commented 7 years ago

cc keanulee@ or ffu@

— Emmanuel

On Thu, May 4, 2017 at 12:18 PM, TAS notifications@github.com wrote:

@blasten https://github.com/blasten Can you take a look on this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PolymerElements/paper-drawer-panel/pull/161#issuecomment-299282979, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWGNVk-Rpk-sCCk_yITduQASX_rqLtEks5r2iSKgaJpZM4LW4_P .