PolymerElements / paper-drawer-panel

A Material Design two-section responsive panel
https://www.webcomponents.org/element/PolymerElements/paper-drawer-panel
25 stars 42 forks source link

Automatic cleanup! #178

Closed e111077 closed 6 years ago

e111077 commented 6 years ago

Tests may fail due to lack of format or types not being updated. It would be much appreciated if the element owner can do that run and help parallelize the work on that front.

e111077 commented 6 years ago

ping

bicknellr commented 6 years ago

This seems to be a legitimate failure in Safari 11.

bicknellr commented 6 years ago

... which is already a problem in master, not related to this PR, AFAICT.

aomarks commented 6 years ago

Tests are failing with a real error:

OS X 10.12 safari 11     ✖ test/small-devices.html » on small devices » drawer can be opened
  AssertionError: expected -256 to equal 0 (http://localhost:8081/components/chai/chai.js:263)
OS X 10.12 safari 11     ✖ test/small-devices.html » on small devices » right-drawer can be closed
  AssertionError: expected 1156 to equal 900 (http://localhost:8081/components/chai/chai.js:263)
e111077 commented 6 years ago

spoken in private: test failures not in scope of this PR; only getting tests to run