PolymerElements / paper-dropdown-menu

A Material Design browser select element
https://www.webcomponents.org/element/PolymerElements/paper-dropdown-menu
61 stars 107 forks source link

Menu value set with item value #118

Closed radagi closed 8 years ago

radagi commented 8 years ago

In case items have 'value' attributes they are used to set the menu 'value'. Doing so also the dropdown menus differenziate between menu label and menu value.

With this fix 'Cars' fields in the iron-form demo for both 'GET' 'and 'POST' cases can generate the same submit parameter (After having associated the right 'value' attributes to the paper-items).

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


radagi commented 8 years ago

I signed the CLA.

googlebot commented 8 years ago

CLAs look good, thanks!

cdata commented 8 years ago

Hi, thank you for your contribution. I'm closing this because it's a dupe of #104 and related PR. Also, it does not follow our guidelines for contributing PRs. Please consult our contribution guidelines for help on filing issues and opening PRs in the future!