search

PolymerElements / paper-dropdown-menu

A Material Design browser select element
https://www.webcomponents.org/element/PolymerElements/paper-dropdown-menu
61 stars 107 forks source link

Fixes #22 #131

Closed miztroh-zz closed 8 years ago

miztroh-zz commented 8 years ago

If no label property exists, try label attribute before falling back to textContent. Added tests.

(added by @bicknellr: Fixes PolymerElements/paper-item#76.)

cdata commented 8 years ago

Thank you for your contribution. I'm going to close this PR for now, since it doesn't have a corresponding issue proposing the design for this feature. Please consult our contribution guidelines for help on filing issues and opening PRs in the future!

miztroh-zz commented 8 years ago

@cdata Have you looked at issue #22? That's the issue this is intended to fix. @notwaldorf marked it as "help wanted". What am I missing?

miztroh-zz commented 8 years ago

This is taken directly from CONTRIBUTING.md:

When submitting pull requests, please provide:

 1. **A reference to the corresponding issue** or issues that will be closed by the pull request. Please refer to these issues in the pull request description using the following syntax:

 (For a single issue)
 Fixes #20

 (For multiple issues)
 Fixes #32, fixes #40

 2. **A succinct description of the design** used to fix any related issues. For example:

 This fixes #20 by removing styles that leaked which would cause the page to turn pink whenever `paper-foo` is clicked.

 3. **At least one test for each bug fixed or feature added** as part of the pull request. Pull requests that fix bugs or add features without accompanying tests will not be considered.

I believe I have met all of these requirements.

miztroh-zz commented 8 years ago

@cdata Will you please reopen?

bicknellr commented 8 years ago

(Fixes PolymerElements/paper-item#76.) I just edited your PR's description to include this, but I really don't like that GitHub doesn't indicate that I edited it or even that it was edited at all.

bicknellr commented 8 years ago

Even more disturbing: I just got an email from GitHub claiming that you made that edit...

miztroh-zz commented 8 years ago

That is weird.

kungufli commented 8 years ago

Any update on this?

miztroh-zz commented 8 years ago

@bicknellr @notwaldorf What else is needed for this to get merged?

bicknellr commented 8 years ago

Everything looks good, sorry about the delay!