first go at readonly - Githubissues

PolymerElements / paper-dropdown-menu

A Material Design browser select element

https://www.webcomponents.org/element/PolymerElements/paper-dropdown-menu

61 stars 107 forks source link

first go at readonly #162

Open christophe-g opened 8 years ago

christophe-g commented 8 years ago

Adding a readonly behavior for paper-dropdown-menu

paper-menu is set to disabled mode
the menu closes when setting to readonly

valdrinkoshi commented 8 years ago

Hi @christophe-g, the implementation LGTM (left a comment). Tests are failing because you need to sync your branch with master. Could you also add some unit tests so we avoid future regressions?

valdrinkoshi commented 8 years ago

Thanks for the contribution @christophe-g! can you add some unit tests to avoid any future regression?