search

PolymerElements / paper-dropdown-menu

A Material Design browser select element
https://www.webcomponents.org/element/PolymerElements/paper-dropdown-menu
61 stars 107 forks source link

Fixes #165: Adds tabindex, fixes focus styles. #167

Closed bicknellr closed 8 years ago

bicknellr commented 8 years ago

Adds tabindex to hostAttributes, removes outline from focus style (focus is shown with underline color / size).

e111077 commented 8 years ago

LGTM, it even works better than the non-light focusing when tabbing quickly on firefox. (the upper ones are the light version)

image

bicknellr commented 8 years ago

I tried it out there and the underline was rendered as only 1px tall, but it wasn't totally missing like the picture above. Weirdly, the position of the bar played an effect here, adjusting bottom by a pixel caused it to render as expected (2px); conveniently, it was already 1px too high so I set it to 7.

e111077 commented 8 years ago

Sorry, I wasn't clear; the light version functions correctly. when tabbing through quickly on Firefox, the light one has the underline appear and disappear. On the non-light version, the underline persists. I completely forgot to file a bug; thanks for the reminder.

cdata commented 8 years ago

LGTM 👍

bicknellr commented 8 years ago

Woot, tests are working again!