Closed bicknellr closed 8 years ago
@bicknellr I've added to the issue in the description to create the link
Implementation looks good, can you add some unit tests please?
After looking at the issue more closely, I think it is better to handle it in paper-menu-button
(responsible of closing the dropdown on selection change). It could have a tap
listener and close the dropdown when that happens. WDYT?
@valdrinkoshi Ok, I'll open a new PR there.
Given that paper-dropdown-menu wraps a paper-menu-button, should paper-dropdown-menu expose the underlying paper-menu-button's close-on-activate flag or just set it automatically? Does anyone not want this behavior for paper-dropdown menus?
Here's the paper-menu-button PR: PolymerElements/paper-menu-button#90. I'll update this one to add / expose close-on-activate
depending on how you think that should work here.
Awesome! Yeah I believe it makes sense to automatically set close-on-activate
here.
LGTM
Adding the
close-on-activate
attribute will close the menu when it receives anyiron-activate
event.Fixes #163, #72