search

PolymerElements / paper-dropdown-menu

A Material Design browser select element
https://www.webcomponents.org/element/PolymerElements/paper-dropdown-menu
61 stars 107 forks source link

div to span #170

Closed valdrinkoshi closed 8 years ago

valdrinkoshi commented 8 years ago

Fixes #153 by changing the role="button" to be a span rather than a div, so that a :before pseudo element can be rendered on the left of the internal paper-menu-button http://jsbin.com/fegoho/4/edit?html,output

bicknellr commented 8 years ago

LGTM

notwaldorf commented 8 years ago

LGTM too. No idea why it needed to be a div and not a span