search

PolymerElements / paper-dropdown-menu

A Material Design browser select element
https://www.webcomponents.org/element/PolymerElements/paper-dropdown-menu
61 stars 107 forks source link

paper-dropdown-menu-light has no focus underline if no-label-float #181

Closed mgiuffrida closed 8 years ago

mgiuffrida commented 8 years ago

The underline does not turn solid blue on focus or tap if no-label-float is on.

<paper-dropdown-menu-light no-label-float>
  <paper-listbox selected="0" class="dropdown-content">
    <paper-item>Foo</paper-item>
    ..

repro: https://jsfiddle.net/9t879aoe/

Possibly related to #179.

mgiuffrida commented 8 years ago

@notwaldorf friendly ping. Would be nice to get a fix for this, but either way a new release would be much appreciated :-)

notwaldorf commented 8 years ago

I done did a release, will take a look at this today

notwaldorf commented 8 years ago

I think this is only reproducible in the shadow DOM; also, I think I have a fix for it!

mgiuffrida commented 8 years ago

Please re-open: there's still no focus underline if the label is set to ''.

You haven't noticed this because the <label hidden$="[[!label]]"> doesn't set |hidden$| until |label| is not undefined, and it starts undefined. If you set the label programmatically and then set it to '', the label hides completely (taking the underline/border with it).

https://jsfiddle.net/7u9bd49p/

notwaldorf commented 8 years ago

@mgiuffrida isn't that technically https://github.com/PolymerElements/paper-dropdown-menu/issues/190?

mgiuffrida commented 8 years ago

@notwaldorf No?