search

PolymerElements / paper-dropdown-menu

A Material Design browser select element
https://www.webcomponents.org/element/PolymerElements/paper-dropdown-menu
61 stars 107 forks source link

Remove the cursor pointer setting #198

Closed dschuyler closed 7 years ago

dschuyler commented 7 years ago

The mouse cursor pointer settings are nicer to have on the paper-menu-button instead of the paper-dropdown-menu. Setting the cursor here cascades into the scroll bar of the dropdown content. It's nicer to set the cursor to pointer in just the trigger within the paper-menu-button.

dschuyler commented 7 years ago

This change is intended to go with https://github.com/PolymerElements/paper-menu-button/pull/104

bicknellr commented 7 years ago

Could you remove these two lines this line also?

https://github.com/PolymerElements/paper-dropdown-menu/pull/198/files#diff-54347db98c04c4bccd8e8f5036683e9aR33

https://github.com/PolymerElements/paper-dropdown-menu/blob/dd0eb79be7d79d33c041d65fe6877c8da53acee4/paper-dropdown-menu-light.html#L178

They're not harming anything but they'll also be redundant after PolymerElements/paper-menu-button#104 is in.

bicknellr commented 7 years ago

and LGTM

bicknellr commented 7 years ago

Actually, I don't think the first line I mentioned should be removed since the input might have UA pointer styling that we're trying to prevent.